ntuple(n, identity) becomes tuple(collect(1:n)...) #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This came up as a fix to the deprecation warning of ```ntuple(n::Integer, f::Function)``` — see JuliaLang/julia#11486, in favor of ```ntuple(f, n)```. But actually, in the special case of ```f``` being the identity (i.e. we merely want to build ```(1, 2, .... n)```), calling ```tuple(collect(1:n)...)``` has the same result and runs always faster on my MacBook. It allocates 2x-4x less memory and runs 1.5x-10x faster. Also, the LLVM code has 2 lines instead of 20.
timholy
added a commit
that referenced
this pull request
Jul 15, 2015
ntuple(n, identity) becomes tuple(collect(1:n)...)
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This came up as a fix to the deprecation warning of
ntuple(n::Integer, f::Function)— see JuliaLang/julia#11486, in favor ofntuple(f, n). But actually, in the special case offbeing the identity (i.e. we merely want to build(1, 2, .... n)), callingtuple(collect(1:n)...)has the same result and runs always faster on my MacBook. It allocates 2x-4x less memory and runs 1.5x-10x faster. Also, the LLVM code has 2 lines instead of 20.What do you think ? Is there are reason why
ntuple(identity, n)should be preferred overtuple(collect(1:n)...)?